Skip to content

docs: minor fix in code #22541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2021
Merged

docs: minor fix in code #22541

merged 1 commit into from
Apr 27, 2021

Conversation

ilmalte
Copy link
Contributor

@ilmalte ilmalte commented Apr 22, 2021

By using suggested coordinates the service returns no directions ("ZERO_RESULTS") and in console is logged: "Directions request returned no results".

I suggest to modify the coordinates with two points that allow the component to render directions.

@ilmalte
docs: minor fix in code
169505f 
By using suggested coordinates the service returns no directions.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 22, 2021
crisbeto
crisbeto approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Apr 23, 2021
@andrewseguin andrewseguin merged commit d8d2c90 into angular:master Apr 27, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilmalte @crisbeto @andrewseguin