Skip to content

chore: fix sigpipe error for commit message #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2016

Conversation

devversion
Copy link
Member

  • When retrieving the last commit message, the script currently pipes it through the head command.

    Since the git log command using the less command will exit immediately the pipe will fail with a 141 exit code (because it can't read from a closed stream)

@jelbourn Sometimes Travis is not publishing the builds due to the mentioned sigpipe signal (which depends on the output of git log --oneline | head -n1).

Here is a snippet which demonstrates the issue
(set -e -o pipefail; test=$ (git log --oneline | head -n1); echo $test; echo $PIPESTATUS[$@])

* When retrieving the last commit message, the script currently pipes it through the head command.
  Since the git log command using the less command will exit immediately the pipe will fail with a 141 exit code (because it can't read from a closed stream)
@devversion devversion requested a review from jelbourn December 16, 2016 18:38
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 16, 2016
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 2d24383 into angular:master Dec 16, 2016
@devversion devversion deleted the chore/publish-sigpipe branch December 16, 2016 18:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants