Skip to content

build: remove dependency on @angular/elements and custom elements polyfill #22586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2021
Merged

build: remove dependency on @angular/elements and custom elements polyfill #22586

merged 1 commit into from
May 3, 2021

Conversation

crisbeto
Copy link
Member

We weren't using @angular/elements for anything and the custom-elements polyfill was only included because of it.

@crisbeto
build: remove dependency on @angular/elements and custom elements pol…
43c482c 
…yfill

We weren't using `@angular/elements` for anything and the `custom-elements` polyfill was only included because of it.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 28, 2021
@crisbeto crisbeto marked this pull request as ready for review April 28, 2021 18:52
@crisbeto crisbeto added merge safe P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels Apr 28, 2021
jelbourn
jelbourn approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Apr 28, 2021
devversion
devversion approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@annieyw annieyw merged commit b59bb84 into angular:master May 3, 2021
annieyw pushed a commit that referenced this pull request May 3, 2021
@crisbeto @annieyw
build: remove dependency on @angular/elements and custom elements pol…
71684a2 
…yfill (#22586)

We weren't using `@angular/elements` for anything and the `custom-elements` polyfill was only included because of it.

(cherry picked from commit b59bb84)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @annieyw