-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material-experimental/mdc-core): update the required MDC version #22608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material-experimental/mdc-core): update the required MDC version #22608
Conversation
- `11.0.0-canary.3201cae47.0` is required due to the use of the `mdc-list-deprecated-item-disabled-text-color` mixin Fixes angular#22409. Related to angular#21968.
996616b
to
105a276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -2,7 +2,7 @@ | |||
# all in-sync. This map is passed to each ng_package rule to stamp out the appropriate | |||
# version for the placeholders. | |||
ANGULAR_PACKAGE_VERSION = "^11.0.0 || ^12.0.0-0" | |||
MDC_PACKAGE_VERSION = "^9.0.0-canary.419e03572.0" | |||
MDC_PACKAGE_VERSION = "^11.0.0-canary.3201cae47.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the version in the package.json be changed too? It's what we use for the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that it matches this version due to #21968.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
11.0.0-canary.3201cae47.0
is required due to the use ofthe
mdc-list-deprecated-item-disabled-text-color
mixinFixes #22409. Related to #21968.