Skip to content

fix(material-experimental/mdc-core): update the required MDC version #22608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2021

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented May 1, 2021

  • 11.0.0-canary.3201cae47.0 is required due to the use of
    the mdc-list-deprecated-item-disabled-text-color mixin

Fixes #22409. Related to #21968.

@Splaktar Splaktar added the dependencies Pull requests that update a dependency file label May 1, 2021
@Splaktar Splaktar requested review from crisbeto and mmalerba May 1, 2021 04:09
@Splaktar Splaktar requested a review from a team as a code owner May 1, 2021 04:09
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 1, 2021
- `11.0.0-canary.3201cae47.0` is required due to the use of
  the `mdc-list-deprecated-item-disabled-text-color` mixin

Fixes angular#22409. Related to angular#21968.
@Splaktar Splaktar force-pushed the fix-material-experimental-mixins branch from 996616b to 105a276 Compare May 1, 2021 04:23
@Splaktar Splaktar changed the title fix(material-experimental): update the required MDC version to 11.0.0-canary.3201cae47.0 fix(material-experimental/mdc-core): update the required MDC version May 1, 2021
@Splaktar Splaktar added the target: patch This PR is targeted for the next patch release label May 1, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,7 +2,7 @@
# all in-sync. This map is passed to each ng_package rule to stamp out the appropriate
# version for the placeholders.
ANGULAR_PACKAGE_VERSION = "^11.0.0 || ^12.0.0-0"
MDC_PACKAGE_VERSION = "^9.0.0-canary.419e03572.0"
MDC_PACKAGE_VERSION = "^11.0.0-canary.3201cae47.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the version in the package.json be changed too? It's what we use for the CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that it matches this version due to #21968.

Splaktar added a commit to DevIntent/material.angular.io that referenced this pull request May 1, 2021
@Splaktar Splaktar added P2 The issue is important to a large percentage of users, with a workaround area: theming labels May 1, 2021
Splaktar added a commit to angular/material.angular.io that referenced this pull request May 1, 2021
@Splaktar Splaktar added the action: merge The PR is ready for merge by the caretaker label May 3, 2021
@mmalerba mmalerba merged commit b5224ea into angular:11.2.x May 13, 2021
@Splaktar Splaktar deleted the fix-material-experimental-mixins branch May 13, 2021 18:10
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: theming cla: yes PR author has agreed to Google's Contributor License Agreement dependencies Pull requests that update a dependency file P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants