Skip to content

fix(material/table): Make table data source interface generic #22673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2021

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented May 12, 2021

Modify the MatTableDataSource interface so that instead of expecting either the legacy MatPaginator or MDC-based MatPaginator, it accepts something with the right API interface and defaults to that.

This change enables users to migrate from the legacy table to the MDC-based table without requiring them to also migrate the pagintor (which then also includes select, thus all form field elements, and button and tooltip).

@andrewseguin andrewseguin requested review from crisbeto and mmalerba May 12, 2021 12:59
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 12, 2021
@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels May 12, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 12, 2021
@mmalerba mmalerba merged commit ee5cf49 into angular:master May 13, 2021
mmalerba pushed a commit that referenced this pull request May 13, 2021
* fix(material/table): Make table data source interface generic

* fix(material/table): golden api

* fix(material/table): re-export interface

(cherry picked from commit ee5cf49)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants