Skip to content

docs(material/form-field): fix handling of error state in the custom … #22782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented May 24, 2021

…form field control docs

Fixes #22558

@mmalerba mmalerba added merge safe target: patch This PR is targeted for the next patch release labels May 24, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 24, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

...
fm.monitor(elRef, true).subscribe(origin => {
this.focused = !!origin;
onFocusIn(event: FocusEvent) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: my preference would be to name these methods something that reflects what they do, but I don't feel super strongly since it's an example

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label May 24, 2021
@wagnermaciel wagnermaciel merged commit 5de7a22 into angular:master May 25, 2021
wagnermaciel pushed a commit that referenced this pull request May 25, 2021
…form field control docs (#22782)

(cherry picked from commit 5de7a22)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs-bug(MatFormField): inconsistency between Custom form field guide and live example for errorState
3 participants