Skip to content

docs(material/select): clarify that MatInputModule is needed for matNativeControl #22793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2021
Merged

docs(material/select): clarify that MatInputModule is needed for matNativeControl #22793

merged 1 commit into from
May 26, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented May 25, 2021 •
edited
Loading

fixes #22118

@mmalerba mmalerba added merge safe target: patch This PR is targeted for the next patch release labels May 25, 2021
@mmalerba mmalerba requested a review from crisbeto as a code owner May 25, 2021 19:14
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 25, 2021
crisbeto
crisbeto approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 26, 2021
@mmalerba mmalerba merged commit 8d95c2f into angular:master May 26, 2021
mmalerba added a commit that referenced this pull request May 26, 2021
@mmalerba
docs(material/select): clarify that MatInputModule is needed for `m…
f292680 
…atNativeControl` (#22793)

(cherry picked from commit 8d95c2f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(mat-select): Native select with matNativeControl requires importing MatInputModule
2 participants
@mmalerba @crisbeto