Skip to content

docs(material/button-toggle): add description for appearance property in default options #22852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Developers can specify a default appearance for button toggles
using the MatButtonToggleDefaultOptions. The appearance property
within these default options is not documented. This commit adds
a description.

… in default options

Developers can specify a default appearance for button toggles
using the `MatButtonToggleDefaultOptions`. The appearance property
within these default options is not documented. This commit adds
a description.
@devversion devversion added docs This issue is related to documentation target: patch This PR is targeted for the next patch release labels Jun 1, 2021
@devversion devversion requested a review from crisbeto June 1, 2021 14:04
@devversion devversion requested a review from jelbourn as a code owner June 1, 2021 14:04
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 1, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the comment is addressed.

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 1, 2021
@mmalerba mmalerba merged commit c65a87b into angular:master Jun 1, 2021
mmalerba pushed a commit that referenced this pull request Jun 1, 2021
… in default options (#22852)

* docs(material/button-toggle): add description for appearance property in default options

Developers can specify a default appearance for button toggles
using the `MatButtonToggleDefaultOptions`. The appearance property
within these default options is not documented. This commit adds
a description.

* fixup! docs(material/button-toggle): add description for appearance property in default options

Address feedback

(cherry picked from commit c65a87b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants