Skip to content

chore: fix minified templates in release #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2016

Conversation

devversion
Copy link
Member

@devversion devversion commented Dec 20, 2016

  • Currently the html-minifier minifies the attributes in a non-case sensitive way and this breaks the templates in the releases.

@jelbourn This one should be very important for releases, because right now the templates in the releases are broken.

* Currently the `html-minifier` minifies the attributes in a non-case sensitive way and this breaks the templates in the releases.
@devversion devversion added this to the before beta milestone Dec 20, 2016
@devversion devversion requested a review from jelbourn December 20, 2016 09:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 20, 2016
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I commented on this on the original PR and then forgot to make sure it was there before merging.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 20, 2016
@devversion
Copy link
Member Author

@jelbourn Oh my bad. I oversaw the caseSensitive property and only added the removeComments option.

@jelbourn jelbourn merged commit 5cfbb17 into angular:master Dec 20, 2016
@devversion devversion deleted the chore/fix-release-templates branch December 20, 2016 18:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants