chore: package.json updates #2293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
* Moves the `router` and `platform-browser-dynamic` to the `devDependencies` since they're only used in tests and the demo app. * Removes a duplicate `@types/selenium-webdriver` which probably got into the `package.json` due to a faulty merge. * Locks down the Selenium typings version in order to prevent Selenium-related type errors. * Adds `selenium-webdriver` to the dev dependencies, otherwise the e2e tests fail to run on a fresh install.
crisbeto
force-pushed
the
unused-dependencies
branch
from
0957782 to
860d022
Compare
crisbeto
changed the title
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
routerandplatform-browser-dynamicto thedevDependenciessince they're only used in tests and the demo app.@types/selenium-webdriverwhich probably got into thepackage.jsondue to a faulty merge.selenium-webdriverto the dev dependencies, otherwise the e2e tests fail to run on a fresh install.