Skip to content

docs: clarify value of the form control in the chips-form-control example #22995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

We recently added an example for chips with a form control. This example
should clarify how the chip list can interact with a form control.

It seems like it is not quite clear what value the form control
represents, or how a chip can be "selected". This has been improved
as per this commit.

Fixes #22933.

…mple

We recently added an example for chips with a form control. This example
should clarify how the chip list can interact with a form control.

It seems like it is not quite clear what value the form control
represents, or how a chip can be "selected". This has been improved
as per this commit.

Fixes angular#22933.
@devversion devversion added docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Jun 16, 2021
@devversion devversion requested a review from crisbeto June 16, 2021 16:01
@devversion devversion requested a review from andrewseguin as a code owner June 16, 2021 16:01
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 16, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 18, 2021
@mmalerba mmalerba merged commit 92d27a8 into angular:master Jun 18, 2021
mmalerba pushed a commit that referenced this pull request Jun 18, 2021
…mple (#22995)

We recently added an example for chips with a form control. This example
should clarify how the chip list can interact with a form control.

It seems like it is not quite clear what value the form control
represents, or how a chip can be "selected". This has been improved
as per this commit.

Fixes #22933.

(cherry picked from commit 92d27a8)
mmalerba pushed a commit that referenced this pull request Jun 18, 2021
…mple (#22995)

We recently added an example for chips with a form control. This example
should clarify how the chip list can interact with a form control.

It seems like it is not quite clear what value the form control
represents, or how a chip can be "selected". This has been improved
as per this commit.

Fixes #22933.

(cherry picked from commit 92d27a8)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs-bug(material/chips): 'Chips with form control' example does not reflect formControl value
3 participants