fix(material/datepicker): correct structure for grid role #23022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
reviewed
Jun 19, 2021
jelbourn
force-pushed
the
datepicker-grid
branch
2 times, most recently
from
22387bf to
0457d09
Compare
crisbeto
approved these changes
Jun 21, 2021
dev054
reviewed
Jun 21, 2021
jelbourn
force-pushed
the
datepicker-grid
branch
from
0457d09 to
ac223c4
Compare
Previously, the grid in mat-datepicker was not strictly following the structure expected for the grid role. Additionally, this change adds an `<abbr>` element to the column headers such that VoiceOver can correctly read column headers. Fixes angular#21357
jelbourn
force-pushed
the
datepicker-grid
branch
from
ac223c4 to
b3d7dbd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the grid in mat-datepicker was not strictly following the structure expected for the grid role. Additionally, this change adds an
<abbr>element to the column headers such that VoiceOver can correctly read column headers.Fixes #21357