build: remove unnecessary env.sh logic for circleci
#23054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
devversion
added
merge safe
target: patch
In the past, when the `checkout_and_rebase` command has been ported from `angular/angular` to the components repo, the `env.sh` w/ `env-helper.inc.sh` scripts have been integrated too. The goal of these scripts is to setup the environment for CircleCI in a CI-agnostic way. Since the only logic relying on the `env.sh` file is the `rebase-pr` script, we can just update the script (located in `.circleci/`) to point directly to the CircleCI variables. This is more readable and makes the CI less convoluted. Especially since the `env.sh` script currently performs duplicate work like settign up the RBE/GCP token. A separate script is already invoked for this using the `*setup_bazel_rbe` YAML macro.
devversion
force-pushed
the
build/cleanup-circleci-env-setup
branch
from
edad6ed to
9e798f7
Compare
amysorto
pushed a commit
that referenced
this pull request
Jun 25, 2021
In the past, when the `checkout_and_rebase` command has been ported from `angular/angular` to the components repo, the `env.sh` w/ `env-helper.inc.sh` scripts have been integrated too. The goal of these scripts is to setup the environment for CircleCI in a CI-agnostic way. Since the only logic relying on the `env.sh` file is the `rebase-pr` script, we can just update the script (located in `.circleci/`) to point directly to the CircleCI variables. This is more readable and makes the CI less convoluted. Especially since the `env.sh` script currently performs duplicate work like settign up the RBE/GCP token. A separate script is already invoked for this using the `*setup_bazel_rbe` YAML macro.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, when the
checkout_and_rebasecommand hasbeen ported from
angular/angularto the components repo,the
env.shw/env-helper.inc.shscripts have been integratedtoo. The goal of these scripts is to setup the environment for
CircleCI in a CI-agnostic way. Since the only logic relying on
the
env.shfile is therebase-prscript, we can justupdate the script (located in
.circleci/) to point directly to theCircleCI variables.
This is more readable and makes the CI less convoluted. Especially
since the
env.shscript currently "intends" to perform duplicate worklike setting up the RBE/GCP token (does not work due to an incorrect
GCP decrypt key being used). A separate script is already invoked for this
using the
*setup_bazel_rbeYAML macro.Also the
env.shfile currently referenced non-existent files likebazel.linux.rc.