build: enable strictFunctionTypes in schematics #23111
Conversation
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
| import * as ts from 'typescript'; | ||
|
|
||
| /** | ||
| * Migration that checks for classes that extend Angular Material classes which | ||
| * have changed their API. | ||
| */ | ||
| export class MiscClassInheritanceMigration extends Migration<null> { | ||
| export class MiscClassInheritanceMigration extends DevkitMigration<null> { |
There was a problem hiding this comment.
Why have these been changed to a DevkitMigration? Is it due to the never/unknown change above for Migration, where they no longer are subtypes of DevkitMigration now? (this is what I wanted to achieve with never in the past).
The goal is to keep them decoupled from DevkitMigration so that these could technically be run within Google where they do not run within a devkit-based project.
There was a problem hiding this comment.
Yeah, pretty much. I noticed that the DevkitMigration doesn't do all that much on top of the Migration so I decided to swap them out. If you think that it's not the correct approach, I can try something else.
There was a problem hiding this comment.
It seems honestly unlikely at the current state that any of the migrations are needed in g3, but we put a lot of work initially into the infrastructure so that we can run them easily in g3 (without having to replicate logic w/ TSlint as in FW), so it would cool to see if we keep it like that, but if it's too much work then I personally don't mind a lot.
There was a problem hiding this comment.
I pushed another change to default the Context to any instead of unknown.
Makes the schematics code compliant with the `strictFunctionTypes` compiler option.
crisbeto
force-pushed
the
schematics-strict-function-types
branch
from
e3ab2df to
6e17502
Compare
Makes the schematics code compliant with the `strictFunctionTypes` compiler option. (cherry picked from commit 2628d27)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Makes the schematics code compliant with the
strictFunctionTypescompiler option.