Skip to content

refactor(cdk/platform): add utility for resolving event targets in shadow dom #23121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2021
Merged

refactor(cdk/platform): add utility for resolving event targets in shadow dom #23121

merged 1 commit into from
Jul 9, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 6, 2021

We were repeating the logic for resolving the event target while accounting for shadow DOM in a few places. These changes add a common utility instead.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 6, 2021
@crisbeto crisbeto requested a review from jelbourn July 6, 2021 19:49
@crisbeto crisbeto requested a review from devversion as a code owner July 6, 2021 19:49
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 6, 2021
@crisbeto crisbeto force-pushed the shadow-dom-event-util branch from 43e48c1 to 60fba37 Compare July 6, 2021 20:32
@crisbeto
refactor(cdk/platform): add utility for resolving event targets in sh…
689d537 
…adow dom

We were repeating the logic for resolving the event target while accounting for shadow DOM in a few places. These changes add a common utility instead.
@crisbeto crisbeto force-pushed the shadow-dom-event-util branch from 60fba37 to 689d537 Compare July 6, 2021 20:35
jelbourn
jelbourn approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jul 7, 2021
@wagnermaciel wagnermaciel merged commit 7fae1a9 into angular:master Jul 9, 2021
wagnermaciel pushed a commit that referenced this pull request Jul 9, 2021
@crisbeto @wagnermaciel
refactor(cdk/platform): add utility for resolving event targets in sh…
f3098d2 
…adow dom (#23121)

We were repeating the logic for resolving the event target while accounting for shadow DOM in a few places. These changes add a common utility instead.

(cherry picked from commit 7fae1a9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @wagnermaciel