Skip to content

perf(cdk/scrolling): don't re-measure viewport on resize #23124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2021
Merged

perf(cdk/scrolling): don't re-measure viewport on resize #23124

merged 1 commit into from
Jul 9, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 6, 2021

We don't need to re-measure the viewport any time it is resized, we just need to clear the cache so that it is re-measured next time somebody requests it.

@crisbeto
perf(cdk/scrolling): don't re-measure viewport on resize
238bc59 
We don't need to re-measure the viewport any time it is resized, we just need to clear the cache so that it is re-measured next time somebody requests it.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 6, 2021
@crisbeto crisbeto requested a review from jelbourn July 6, 2021 21:51
@crisbeto crisbeto requested a review from andrewseguin as a code owner July 6, 2021 21:51
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 6, 2021
jelbourn
jelbourn approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jul 7, 2021
@wagnermaciel wagnermaciel merged commit fec20ad into angular:master Jul 9, 2021
wagnermaciel pushed a commit that referenced this pull request Jul 9, 2021
@crisbeto @wagnermaciel
perf(cdk/scrolling): don't re-measure viewport on resize (#23124)
dec3ab0 
We don't need to re-measure the viewport any time it is resized, we just need to clear the cache so that it is re-measured next time somebody requests it.

(cherry picked from commit fec20ad)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @wagnermaciel