build: update to rules_nodejs v4.0.0-beta.0 and use new API golden tool #23155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
devversion
force-pushed
the
nodejs-api-update
branch
6 times, most recently
from
1e10819 to
069758e
Compare
devversion
added
merge safe
target: patch
devversion
requested review from
andrewseguin,
jelbourn,
mmalerba and
a team
as code owners
devversion
commented
Jul 13, 2021
| @@ -13,7 +13,7 @@ import {ComponentFixture, TestBed, waitForAsync} from '@angular/core/testing'; | |||
| import {By} from '@angular/platform-browser'; | |||
| import {CdkComboboxModule} from './combobox-module'; | |||
| import {CdkCombobox} from './combobox'; | |||
| import {dispatchKeyboardEvent, dispatchMouseEvent} from '@angular/cdk/testing/private'; | |||
| import {dispatchKeyboardEvent, dispatchMouseEvent} from '../../cdk/testing/private'; | |||
There was a problem hiding this comment.
Just for reference: There are a couple of similar changes. Such internal files should not be imported through a module name, but rather through a relative source import. This will help with distinguishing between public modules and internal/test-only ones.
Updates the Bazel NodeJS rules to v4.0.0-beta.0. This is necessary so that the Angular components repo can start using the new API golden tool from the shared dev-infra repository, and it's generally good to stay as up-to-date as possible with the Bazel rules as it's easy to fall behind, and updating early allows us to discover issues affecting our tooling earlier (where they are easier to address due to e.g. potential breaking change policy). bazel-contrib/rules_nodejs@3be2902. As part of this change, we remove all manual `module_name` properties from `ts_library` and `ng_module` targets. These will be generated now as manually setting the module name is rather prone to mistakes and this way it also integrates better with the new `package_name` property introduced as part of Rules NodeJS v4. This change reveiled that we set a module name for the private `material/testing` folder. This folder no longer will resolve through `@angular/material` and needs to be imported through a relative path.
We recently introduced a new tool for testing the public API signature of entry-points. This tool is part of the shared dev-infra package and uses Microsoft's API extractor under the hood. This commit sets up the new tool and removes ts-api-guardian.
The API goldens have been flattened as part of 766b07e, but the script for updating goldens has not been updated. This commit fixes the script so that it respects the new file location of goldens.
devversion
force-pushed
the
nodejs-api-update
branch
from
069758e to
d241cd9
Compare
devversion
added
action: merge
amysorto
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits (due to a lot of changes files; this is easier for review)
This also contains angular/angular#42814 which should fix our flakiness within RBE