Skip to content

build: add vim swamp files to .gitignore #23173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2021
Merged

build: add vim swamp files to .gitignore #23173

merged 1 commit into from
Jul 15, 2021

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Jul 14, 2021

Adds vim swamp files to .gitignore. This aligns us with the framework repo: https://github.com/angular/angular/blob/master/.gitignore#L21

@zarend zarend added the target: patch This PR is targeted for the next patch release label Jul 14, 2021
@zarend zarend requested a review from jelbourn July 14, 2021 23:39
@zarend zarend requested a review from a team as a code owner July 14, 2021 23:39
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 14, 2021
josephperrott
josephperrott approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend zarend added action: merge The PR is ready for merge by the caretaker merge safe labels Jul 14, 2021
@zarend zarend removed the request for review from jelbourn July 14, 2021 23:42
@crisbeto
Copy link
Member

I think that you need to switch the commit message from chore to build in order to pass the lint check.

@zarend zarend changed the title chore: add vim swamp files to .gitignore build: add vim swamp files to .gitignore Jul 15, 2021
@amysorto amysorto merged commit 2acd218 into angular:master Jul 15, 2021
amysorto pushed a commit that referenced this pull request Jul 15, 2021
@zarend @amysorto
build: add vim swamp files to .gitignore (#23173)
9a19f92 
(cherry picked from commit 2acd218)
@zarend zarend deleted the gitignore-vim branch July 23, 2021 18:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zarend @crisbeto @devversion @josephperrott @amysorto