docs: add jsdoc annotations everywhere #2321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds JSDoc annotations to all of the public properties and methods that were missing them. Also cleans up some random issues that were noticed while going through everything.
googlebot
added
the
cla: yes
devversion
reviewed
Dec 21, 2016
| @@ -98,10 +98,12 @@ export class MdButtonToggleGroup implements AfterViewInit, ControlValueAccessor | |||
| @ContentChildren(forwardRef(() => MdButtonToggle)) | |||
| _buttonToggles: QueryList<MdButtonToggle> = null; | |||
|
|
|||
| /** @docs-private */ | |||
| ngAfterViewInit() { | |||
There was a problem hiding this comment.
All the lifecycle hooks should be already filtered in this processor
| * Gets whether an element is disabled. | ||
| * | ||
| * @param element Element to be checked. | ||
| * @returns {boolean} Whether the element is disabled. |
| @@ -9,16 +9,22 @@ import { | |||
| AfterContentInit | |||
| } from '@angular/core'; | |||
|
|
|||
| /** | |||
| * Directive that triggers a callback whenever the content of | |||
| * it's associated element has changed. | |||
|
LGTM; I'll make any tweaks after merging |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds JSDoc annotations to all of the public properties and methods that were missing them. Also cleans up some random issues that were noticed while going through everything.
Note: I've skipped the toolbar component since @devversion mentioned that he's doing it already.