test(material/slide-toggle): fix test flakes #23332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
slide-toggle-test-flakes
branch
2 times, most recently
from
4cd0e3c to
6cec8cd
Compare
Attempts to fix some of the recent slide toggle test flakes by making all tests `fakeAsync` and adding the missing flushes. **Note:** while we don't technically need `fakeAsync` everywhere now that we know which tests are problematic, I did it anyway for consistency.
crisbeto
force-pushed
the
slide-toggle-test-flakes
branch
from
6cec8cd to
5217850
Compare
devversion
approved these changes
Aug 10, 2021
andrewseguin
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix some of the recent slide toggle test flakes by making all tests
fakeAsyncand adding the missing flushes.Note: while we don't technically need
fakeAsynceverywhere now that we know which tests are problematic, I did it anyway for consistency.