build: switch to release tool from dev-infra #23333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
devversion
force-pushed
the
release-tool-shared
branch
2 times, most recently
from
18e85e2 to
ebc0636
Compare
devversion
added
merge safe
target: patch
devversion
commented
Aug 9, 2021
devversion
force-pushed
the
release-tool-shared
branch
from
ebc0636 to
f203867
Compare
devversion
added
target: major
|
I've tested various scenarios of the tool in my forks (this took most of the time; the tool is difficult to test). Everything worked well based on the things I could test. Obviously the testing does not include the Wombat registry so that is kind of unknown to me. Other than that, "It should work"™️ 😄 |
Switches to the release tool from the shared dev-infra package. This script is more aligned with the versioning and branching the whole Angular organization follows as this point. We work around a couple of APIs that need to be discussed within the release tool in order to wire up custom release stage / publish validations. We still want to keep them for now so we use some monkey-patching (which is acceptable for the interim until we have determined which checks should be built-in / how consumers can wire up additional checks)
Remove wombat registry explicit entries
Address feedback
devversion
force-pushed
the
release-tool-shared
branch
from
c466109 to
cdd6699
Compare
devversion
requested review from
crisbeto and
josephperrott
and removed request for
crisbeto
|
@devversion Do we need to create a patch version of this to allow for the tool to know how to build the patch releases going forward? |
|
@josephperrott yeah, that's the plan. Since some new packages are not in patch, I will send a separate PR. |
devversion
added a commit
to devversion/material2
that referenced
this pull request
Aug 11, 2021
* build: switch to release tool from dev-infra Switches to the release tool from the shared dev-infra package. This script is more aligned with the versioning and branching the whole Angular organization follows as this point. We work around a couple of APIs that need to be discussed within the release tool in order to wire up custom release stage / publish validations. We still want to keep them for now so we use some monkey-patching (which is acceptable for the interim until we have determined which checks should be built-in / how consumers can wire up additional checks) * fixup! build: switch to release tool from dev-infra Remove wombat registry explicit entries * fixup! build: switch to release tool from dev-infra Address feedback
andrewseguin
pushed a commit
that referenced
this pull request
Aug 11, 2021
* build: switch to release tool from dev-infra Switches to the release tool from the shared dev-infra package. This script is more aligned with the versioning and branching the whole Angular organization follows as this point. We work around a couple of APIs that need to be discussed within the release tool in order to wire up custom release stage / publish validations. We still want to keep them for now so we use some monkey-patching (which is acceptable for the interim until we have determined which checks should be built-in / how consumers can wire up additional checks) * fixup! build: switch to release tool from dev-infra Remove wombat registry explicit entries * fixup! build: switch to release tool from dev-infra Address feedback
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to the release tool from the shared dev-infra
package. This script is more aligned with the versioning
and branching the whole Angular organization follows as this
point.
We work around a couple of APIs that need to be discussed
within the release tool in order to wire up custom release
stage / publish validations. We still want to keep them for
now so we use some monkey-patching (which is acceptable for
the interim until we have determined which checks should be
built-in / how consumers can wire up additional checks)