Skip to content

fix(cdk/drag-drop): add conditional to scroll update #23337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

andrewseguin
Copy link
Contributor

Fix proposed by internal user to fix an issue with dragging. Open for discussion on whether this fix is valid.

@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Aug 10, 2021
@andrewseguin andrewseguin requested a review from crisbeto August 10, 2021 17:18
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 10, 2021
@crisbeto
Copy link
Member

What issue is this supposed to fix? The idea with this block of code is to update the cached dimensions whenever something within the container is scrolled. I think that would be valid when the container itself is scrolled too.

@andrewseguin
Copy link
Contributor Author

When dragging an item in a list where there's a scrollbar, the item gets stuck in place while the list scrolls.

Here's a reproduction: #23337

You'll have to copy/paste the reproduction into the dev-app to see it against the latest changes.

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 11, 2021
@andrewseguin andrewseguin added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Aug 11, 2021
@andrewseguin andrewseguin merged commit 219e1f5 into angular:master Aug 11, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants