build: fix staging sanity release checks picking up incorrect packages #23346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the new release tool hacks around the ng-dev publish tool in order to run staging sanity checks. The logic is currently running in the same Node process that started the publish process from `master`. This results in the sanity checks accidentally receiving a cached list of release packages, instead of the one local to the publish branch (like `12.2.x`build: fix staging sanity release checks picking up incorrect packages Currently the new release tool hacks around the ng-dev publish tool in order to run staging sanity checks. The logic is currently running in the same Node process that started the publish process from `master`. This results in the sanity checks accidentally receiving a cached list of release packages, instead of the one local to the publish branch (like `12.2.x`)
devversion
added
merge safe
target: patch
google-cla
bot
added
the
cla: yes
andrewseguin
approved these changes
Aug 11, 2021
andrewseguin
pushed a commit
that referenced
this pull request
Aug 11, 2021
#23346) Currently the new release tool hacks around the ng-dev publish tool in order to run staging sanity checks. The logic is currently running in the same Node process that started the publish process from `master`. This results in the sanity checks accidentally receiving a cached list of release packages, instead of the one local to the publish branch (like `12.2.x`build: fix staging sanity release checks picking up incorrect packages Currently the new release tool hacks around the ng-dev publish tool in order to run staging sanity checks. The logic is currently running in the same Node process that started the publish process from `master`. This results in the sanity checks accidentally receiving a cached list of release packages, instead of the one local to the publish branch (like `12.2.x`) (cherry picked from commit 0ed1cbe)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the new release tool hacks around the ng-dev publish
tool in order to run staging sanity checks. The logic is
currently running in the same Node process that started
the publish process from
master. This results in thesanity checks accidentally receiving a cached list of
release packages, instead of the one local to the publish
branch (like
12.2.xbuild: fix staging sanity release checks picking upincorrect packages
Currently the new release tool hacks around the ng-dev publish
tool in order to run staging sanity checks. The logic is
currently running in the same Node process that started
the publish process from
master. This results in thesanity checks accidentally receiving a cached list of
release packages, instead of the one local to the publish
branch (like
12.2.x)