Skip to content

docs(cdk/stepper): change misleading documentation #23377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

crisbeto
Copy link
Member

The "Accessibility' section of the stepper docs was talking about the stepper having built-in accessibility treatment, even though it doesn't have any, because we don't have control over the component's markup.

These changes reword the section to make it more accurate.

Fixes #23044.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Aug 15, 2021
@crisbeto crisbeto requested a review from jelbourn August 15, 2021 13:44
@crisbeto crisbeto requested a review from mmalerba as a code owner August 15, 2021 13:44
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 15, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for documenting the state of the world today, though I may want to changed this at some point.

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 28, 2021
The "Accessibility' section of the stepper docs was talking about the stepper having built-in accessibility treatment, even though it doesn't have any, because we don't have control over the component's markup.

These changes reword the section to make it more accurate.

Fixes angular#23044.
@mmalerba mmalerba merged commit 46779b3 into angular:master Aug 31, 2021
mmalerba pushed a commit that referenced this pull request Aug 31, 2021
The "Accessibility' section of the stepper docs was talking about the stepper having built-in accessibility treatment, even though it doesn't have any, because we don't have control over the component's markup.

These changes reword the section to make it more accurate.

Fixes #23044.

(cherry picked from commit 46779b3)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(CdkStepper): Does not automatically assign roles or aria labels for accessibility like it says it will in the documentation
3 participants