Skip to content

refactor(material/core): remove extra version constant #23482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2022
Merged

refactor(material/core): remove extra version constant #23482

merged 1 commit into from
Jan 13, 2022

Conversation

crisbeto
Copy link
Member

Cleans up an extra VERSION constant that was put in place for something that shouldn't be an issue anymore.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 27, 2021
@crisbeto crisbeto requested a review from devversion August 27, 2021 19:42
@crisbeto crisbeto marked this pull request as ready for review August 27, 2021 19:42
@crisbeto crisbeto requested a review from jelbourn as a code owner August 27, 2021 19:42
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Aug 27, 2021
jelbourn
jelbourn approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 28, 2021
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@crisbeto
refactor(material/core): remove extra version constant
cf1b36f 
Cleans up an extra `VERSION` constant that was put in place for something that shouldn't be an issue anymore.
@crisbeto crisbeto force-pushed the core-extra-version branch from 692a4a9 to cf1b36f Compare January 3, 2022 09:26
@andrewseguin andrewseguin merged commit 275b05e into angular:master Jan 13, 2022
andrewseguin pushed a commit that referenced this pull request Jan 13, 2022
@crisbeto @andrewseguin
refactor(material/core): remove extra version constant (#23482)
6cec795 
Cleans up an extra `VERSION` constant that was put in place for something that shouldn't be an issue anymore.

(cherry picked from commit 275b05e)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @devversion @googlebot @andrewseguin