Skip to content

build: bump to latest sass version #23599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2021
Merged

build: bump to latest sass version #23599

merged 1 commit into from
Sep 19, 2021

Conversation

crisbeto
Copy link
Member

Updates us to Sass version 1.41.0, because it includes some potentially breaking changes related to calc.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: major This PR is targeted for the next major release labels Sep 17, 2021
@crisbeto crisbeto requested a review from jelbourn September 17, 2021 18:11
@crisbeto crisbeto requested a review from a team as a code owner September 17, 2021 18:11
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 17, 2021
@crisbeto crisbeto changed the title build: bump to sass version build: bump to latest sass version Sep 17, 2021
@crisbeto
Copy link
Member Author

Looks like this reveals an error in MDC. Blocking this for now until it's resolved.

@crisbeto crisbeto added blocked This issue is blocked by some external factor, such as a prerequisite PR and removed merge safe labels Sep 17, 2021
@crisbeto
build: bump sass version
e6d63a0 
Updates us to Sass version 1.41.0, because it includes some potentially breaking changes related to `calc`.
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge safe and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Sep 18, 2021
@crisbeto
Copy link
Member Author

Looks like MDC merged in a fix yesterday. Unblocking.

@wagnermaciel wagnermaciel merged commit caec3fa into angular:master Sep 19, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @wagnermaciel