-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(material/tabs): expand nav-tab a11y guidance #23705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I imagine we'll edit/add to this guidance in the future, but it looks great for now. Thanks @jelbourn!
src/material/tabs/tabs.md
Outdated
tabs would change the browser URL. For all navigation, including with `MatTabNavBar`, always move | ||
browser focus to an element at the beginning of the content to which the user is navgating. | ||
Furthermore, consider placing your `<router-outlet>` inside of a | ||
[landmark region](https://www.w3.org/TR/wai-aria-1.1/#dfn-landmark) appropropriate to the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: appropriate
b6b38d9
to
4fdcbcb
Compare
Expands the a11y guidance for nav-tabs to mention focus manage and potentially setting an aria landmark.
4fdcbcb
to
c8c6cde
Compare
Expands the a11y guidance for nav-tabs to mention focus manage and potentially setting an aria landmark. (cherry picked from commit fc751ae)
Expands the a11y guidance for nav-tabs to mention focus manage and potentially setting an aria landmark. (cherry picked from commit fc751ae)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Expands the a11y guidance for nav-tabs to mention focus manage and potentially setting an aria landmark.
cc @zarend