Skip to content

docs(material/tabs): expand nav-tab a11y guidance #23705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Oct 7, 2021

Expands the a11y guidance for nav-tabs to mention focus manage and potentially setting an aria landmark.

cc @zarend

@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Oct 7, 2021
@jelbourn jelbourn requested a review from zelliott October 7, 2021 16:32
@jelbourn jelbourn requested a review from andrewseguin as a code owner October 7, 2021 16:32
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 7, 2021
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@zelliott zelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I imagine we'll edit/add to this guidance in the future, but it looks great for now. Thanks @jelbourn!

tabs would change the browser URL. For all navigation, including with `MatTabNavBar`, always move
browser focus to an element at the beginning of the content to which the user is navgating.
Furthermore, consider placing your `<router-outlet>` inside of a
[landmark region](https://www.w3.org/TR/wai-aria-1.1/#dfn-landmark) appropropriate to the page.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: appropriate

Expands the a11y guidance for nav-tabs to mention focus manage and potentially setting an aria landmark.
@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 8, 2021
@zarend zarend merged commit fc751ae into angular:master Oct 12, 2021
zarend pushed a commit that referenced this pull request Oct 12, 2021
Expands the a11y guidance for nav-tabs to mention focus manage and potentially setting an aria landmark.

(cherry picked from commit fc751ae)
zarend pushed a commit that referenced this pull request Oct 12, 2021
Expands the a11y guidance for nav-tabs to mention focus manage and potentially setting an aria landmark.

(cherry picked from commit fc751ae)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants