build: prevent binding BrowserSync UI server during test execution #23733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
devversion
reviewed
Oct 12, 2021
trik
force-pushed
the
disable-browser-sync-ui-listen
branch
from
fd18f41 to
95272ba
Compare
devversion
approved these changes
Oct 12, 2021
| @@ -16,12 +16,12 @@ const {root_paths: _rootPathsRaw, port, historyApiFallback} = | |||
| minimist(args, {boolean: 'historyApiFallback'}); | |||
| const rootPaths = _rootPathsRaw ? _rootPathsRaw.split(',') : ['/']; | |||
|
|
|||
| const server = new DevServer(port, rootPaths, historyApiFallback); | |||
| const bindUi = process.env.TEST_TARGET === undefined; | |||
There was a problem hiding this comment.
Optional when you have time: A small comment would be good here, saying that for tests like e2e the UI is not reasonable to serve, and it could cause port conflicts.
devversion
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running e2e tests locally on macOS raises various EADDRINUSE errors due to browsersync UI server trying to bind multiple times on the same port. furthermore it's not really useful having ui server running in ci tests execution