Skip to content

build: remove init test environment calls from harness examples #23853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

Removes the init test environment calls from the harness examples. This
is meant to make the examples a little more readable, and easier to
integrate within CLI projects (especially when are starting to use
a plain CLI project as foundation for our StackBlitz examples).

The CLI sets up the test environment in a global test init file, so
we should make this assumption in our examples as well. This also helps
with reducing duplication in our code base.

Removes the init test environment calls from the harness examples. This
is meant to make the examples a little more readable, and easier to
integrate within CLI projects (especially when are starting to use
a plain CLI project as foundation for our StackBlitz examples).

The CLI sets up the test environment in a global test init file, so
we should make this assumption in our examples as well. This also helps
with reducing duplication in our code base.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 28, 2021
@devversion devversion added merge safe target: rc This PR is targeted for the next release-candidate labels Oct 28, 2021
@devversion devversion marked this pull request as ready for review October 28, 2021 18:14
@devversion
Copy link
Member Author

This is needed so that we can use a single CLI project boilerplate in material.angular.io for our examples, instead of having to maintain a custom second boilerplate to run harness example tests.

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
Copy link
Member

I think that this will break the existing examples on Stackblitz. See https://stackblitz.com/edit/angular-ckj7yf?file=src%2Fapp%2Fbadge-harness-example.spec.ts

@devversion
Copy link
Member Author

@crisbeto yeah, we will be changing these though. I have a PR coming up for that in a few minutes. I will hold of adding merge ready until that one lands in material.angular.io (#23853 (comment))

@devversion devversion added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Oct 30, 2021
@jelbourn jelbourn merged commit 88b718e into angular:master Nov 2, 2021
jelbourn pushed a commit that referenced this pull request Nov 2, 2021
Removes the init test environment calls from the harness examples. This
is meant to make the examples a little more readable, and easier to
integrate within CLI projects (especially when are starting to use
a plain CLI project as foundation for our StackBlitz examples).

The CLI sets up the test environment in a global test init file, so
we should make this assumption in our examples as well. This also helps
with reducing duplication in our code base.

(cherry picked from commit 88b718e)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants