-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: remove init test environment calls from harness examples #23853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove init test environment calls from harness examples #23853
Conversation
Removes the init test environment calls from the harness examples. This is meant to make the examples a little more readable, and easier to integrate within CLI projects (especially when are starting to use a plain CLI project as foundation for our StackBlitz examples). The CLI sets up the test environment in a global test init file, so we should make this assumption in our examples as well. This also helps with reducing duplication in our code base.
This is needed so that we can use a single CLI project boilerplate in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think that this will break the existing examples on Stackblitz. See https://stackblitz.com/edit/angular-ckj7yf?file=src%2Fapp%2Fbadge-harness-example.spec.ts |
@crisbeto yeah, we will be changing these though. I have a PR coming up for that in a few minutes. I will hold of adding merge ready until that one lands in material.angular.io (#23853 (comment)) |
Removes the init test environment calls from the harness examples. This is meant to make the examples a little more readable, and easier to integrate within CLI projects (especially when are starting to use a plain CLI project as foundation for our StackBlitz examples). The CLI sets up the test environment in a global test init file, so we should make this assumption in our examples as well. This also helps with reducing duplication in our code base. (cherry picked from commit 88b718e)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Removes the init test environment calls from the harness examples. This
is meant to make the examples a little more readable, and easier to
integrate within CLI projects (especially when are starting to use
a plain CLI project as foundation for our StackBlitz examples).
The CLI sets up the test environment in a global test init file, so
we should make this assumption in our examples as well. This also helps
with reducing duplication in our code base.