Skip to content

build: do not accidentally cache undesired files in github action #23875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2021
Merged

build: do not accidentally cache undesired files in github action #23875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/actions/yarn-install/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ runs:
- uses: actions/cache@v2
with:
path: |
**/node_modules
./node_modules/
# Cache key. Whenever the postinstall patches change, the cache needs to be invalidated.
# If just the `yarn.lock` file changes, the most recent cache can be restored though.
# See: https://docs.github.com/en/actions/guides/caching-dependencies-to-speed-up-workflows#example-using-the-cache-action.
key: v2-${{hashFiles('tools/postinstall/apply-patches.js')}}-${{hashFiles('yarn.lock')}}
restore-keys: v2-${{hashFiles('tools/postinstall/apply-patches.js')}}-
key: v3-${{hashFiles('tools/postinstall/apply-patches.js')}}-${{hashFiles('yarn.lock')}}
restore-keys: v3-${{hashFiles('tools/postinstall/apply-patches.js')}}-

- run: yarn install --frozen-lockfile --non-interactive
shell: bash
6 changes: 4 additions & 2 deletions .github/workflows/build-dev-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,13 @@ jobs:
GCP_DECRYPT_TOKEN: angular

# Build the web package. Note that we also need to make the Github environment
# variables available so that the RBE is configured.
# variables available so that the RBE is configured. Note: We run Bazel from a
# low-resource Github action container, so we manually need to instruct Bazel to run
# more actions concurrently as by default this is computed based on the host resources.
- name: Building dev-app
run: |
source ${GITHUB_ENV}
bazel build //src/dev-app:web_package --symlink_prefix=dist/
bazel build //src/dev-app:web_package --symlink_prefix=dist/ --jobs=32

# Prepare the workflow artifact that is available for the deploy workflow. We store the pull
# request number and SHA in a file that can be read by the deploy workflow. This is necessary
Expand Down