Skip to content

chore: use gulp-connect as webserver #2409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2016

Conversation

devversion
Copy link
Member

  • No longer rebuilds all components when changes have been recognized in the dev-app.
  • Allows us to only reload when gulp already recognized a change (no need for filtering and extra watchers)
  • No longer injects CSS as the previous live-server (injecting CSS does not work for Angular 2)

Short summary: Fixes live-reloading in the demo-app when doing changes in the demo-app.

gulp-server-livereload has no easy way to disable the injection of CSS.

* No longer rebuilds all components when changes have been recognized in the dev-app.
* Allows us to only reload when gulp already recognized a change (no need for filtering and extra watchers)
* No longer injects CSS as the previous live-server (injecting CSS does not work for Angular 2)
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 26, 2016
@devversion devversion requested a review from jelbourn December 26, 2016 13:00
@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 28, 2016
@jelbourn jelbourn merged commit 7cee84d into angular:master Dec 28, 2016
@devversion devversion deleted the chore/server-refactor branch December 28, 2016 08:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants