Skip to content

style(_button-base.scss): change Length Unit from px to % #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

RichOren
Copy link
Contributor

$md-icon-button-border-radius change to be 50% of size instead of 50px.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 29, 2016
@hansl
Copy link
Contributor

hansl commented Mar 29, 2016

Could you clarify the reasons behind this PR? Your message only state what you did, which is evident, but not why you did it.

@jelbourn
Copy link
Member

@hansl the 50px was a mistake, it should always have been 50%

LGTM

@jelbourn jelbourn closed this in 4f78c8c Mar 30, 2016
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Oct 15, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants