Skip to content

docs(material/chips): add chips avatar sample #24449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2022

Conversation

AlirezaEbrahimkhani
Copy link
Contributor

resolves #22905

@andrewseguin andrewseguin added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Feb 18, 2022
@AlirezaEbrahimkhani
Copy link
Contributor Author

@andrewseguin
Hi ! I made the changes you mentioned

@andrewseguin andrewseguin added merge safe target: patch This PR is targeted for the next patch release labels Feb 18, 2022
@andrewseguin
Copy link
Contributor

andrewseguin commented Feb 18, 2022

Looks good - one more thing, you'll be able to make the linter happy if you use material/chips in the scope of your commit message:

docs(material/chips): add chips example with avatars

Change the ending > tag markers to be on the same line as their opening and add more description about chips avatar example
change image alts from "shiba1 image" to "Photo of a Shiba Inu"
@AlirezaEbrahimkhani
Copy link
Contributor Author

@andrewseguin
Thanks for the full review.
I made the changes you mentioned.

@AlirezaEbrahimkhani AlirezaEbrahimkhani changed the title docs(chips): add chips avatar sample docs(material/chips): add chips avatar sample Feb 19, 2022
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Feb 21, 2022
@andrewseguin andrewseguin merged commit 29b0a61 into angular:master Feb 21, 2022
andrewseguin pushed a commit that referenced this pull request Feb 21, 2022
* docs(material/chips): add chips avatar sample

resolves #22905

* docs(material/chips): the ending > tag markers and add description

Change the ending > tag markers to be on the same line as their opening and add more description about chips avatar example

* docs(material/chips): change image alt

change image alts from "shiba1 image" to "Photo of a Shiba Inu"

(cherry picked from commit 29b0a61)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs-bug(MatChips): there's no docs for MatChipAvatar
2 participants