Skip to content

fix(tooltip): better handling of multi-line text #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2017
Merged

fix(tooltip): better handling of multi-line text #2472

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09df067
fix(tooltip): better handling of multi-line text
crisbeto Dec 30, 2016
e7590cc
Go back to "white".
crisbeto Jan 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/lib/tooltip/tooltip.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,23 @@
@import '../core/a11y/a11y';


$md-tooltip-height: 22px;
$md-tooltip-target-height: 22px;
$md-tooltip-font-size: 10px;
$md-tooltip-margin: 14px;
$md-tooltip-padding: 8px;
$md-tooltip-horizontal-padding: 8px;
$md-tooltip-vertical-padding: ($md-tooltip-target-height - $md-tooltip-font-size) / 2;

:host {
pointer-events: none;
}

.md-tooltip {
color: white;
padding: 0 $md-tooltip-padding;
color: #fff;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer using white since it's more meaningful; the css minifier will condense it.

padding: $md-tooltip-vertical-padding $md-tooltip-horizontal-padding;
border-radius: 2px;
font-family: $md-font-family;
font-size: 10px;
font-size: $md-tooltip-font-size;
margin: $md-tooltip-margin;
height: $md-tooltip-height;
line-height: $md-tooltip-height;

@include cdk-high-contrast {
outline: solid 1px;
Expand Down