Skip to content

update(overlay): use boolean-property coercion function #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2017
Merged

update(overlay): use boolean-property coercion function #2487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/core/overlay/overlay-directives.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {ConnectedPositionStrategy} from './position/connected-position-strategy'
import {Subscription} from 'rxjs/Subscription';
import {Dir, LayoutDirection} from '../rtl/dir';
import {Scrollable} from './scroll/scrollable';
import {coerceBooleanProperty} from '../coercion/boolean-property';

/** Default set of positions for the overlay. Follows the behavior of a dropdown. */
let defaultPositionList = [
Expand Down Expand Up @@ -121,9 +122,8 @@ export class ConnectedOverlayDirective implements OnDestroy {
return this._hasBackdrop;
}

// TODO: move the boolean coercion logic to a shared function in core
set hasBackdrop(value: any) {
this._hasBackdrop = value != null && `${value}` !== 'false';
this._hasBackdrop = coerceBooleanProperty(value);
}

@Input()
Expand Down