Skip to content

refactor(material-experimental/mdc-snack-bar): remove MDC adapter usage #24997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2022
Merged

refactor(material-experimental/mdc-snack-bar): remove MDC adapter usage #24997

merged 1 commit into from
Jun 2, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 31, 2022 •
edited
Loading

Reworks the MDC snack bar so that it reuses the logic from our existing implementation instead of going through the MDC adapter.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels May 31, 2022
@crisbeto crisbeto requested review from andrewseguin and a team as code owners May 31, 2022 07:48
@crisbeto crisbeto force-pushed the mdc-snackbar-no-adapter branch 4 times, most recently from 7c5c900 to 043d7f0 Compare May 31, 2022 12:57
@crisbeto
refactor(material-experimental/mdc-snack-bar): remove MDC adapter usage
5a31bdf 
Reworks the MDC snack bar so that it reuses the logic from our existing implementation instead of going through the MDC adapter.
@crisbeto crisbeto force-pushed the mdc-snackbar-no-adapter branch from 043d7f0 to 5a31bdf Compare May 31, 2022 13:00
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label May 31, 2022
@crisbeto crisbeto self-assigned this May 31, 2022
josephperrott
josephperrott approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels Jun 2, 2022
@crisbeto crisbeto merged commit 35d230b into angular:main Jun 2, 2022
crisbeto added a commit that referenced this pull request Jun 2, 2022
@crisbeto
refactor(material-experimental/mdc-snack-bar): remove MDC adapter usa…
781cd1f 
…ge (#24997)

Reworks the MDC snack bar so that it reuses the logic from our existing implementation instead of going through the MDC adapter.

(cherry picked from commit 35d230b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @josephperrott @andrewseguin