fix(cdk/schematics): remove instanceof check since it was always false when checking if a directory exists #24999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e when checking if a directory exists
devversion
approved these changes
May 31, 2022
devversion
reviewed
May 31, 2022
| // packages / whether there are multiple versions installed. Typescript | ||
| // throws a compilation error if the type isn't specified and we can't | ||
| // check the type, so we have to cast the error output to any. | ||
| if ((e as any).constructor.name === 'PathIsDirectoryException') { |
There was a problem hiding this comment.
For additional context in this PR: It was unclear to us why specifically the error instanceof check did not work anymore, but likely due to the schematics being run in another sandbox context.
devversion
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.