build: update to Angular 14 stable #25027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
a team,
andrewseguin and
devversion
as code owners
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Jun 5, 2022
`@angular/bazel` currently uses an older version of `@microsoft/api-extractor` which is causing downstream issues in Components. These changes bump up to a version that has a fix. Context: angular/components#25027
|
Blocked until angular/angular#46259 is released. |
crisbeto
added
the
blocked
alxhub
pushed a commit
to angular/angular
that referenced
this pull request
Jun 6, 2022
`@angular/bazel` currently uses an older version of `@microsoft/api-extractor` which is causing downstream issues in Components. These changes bump up to a version that has a fix. Context: angular/components#25027 PR Close #46259
alxhub
pushed a commit
to angular/angular
that referenced
this pull request
Jun 6, 2022
`@angular/bazel` currently uses an older version of `@microsoft/api-extractor` which is causing downstream issues in Components. These changes bump up to a version that has a fix. Context: angular/components#25027 PR Close #46259
devversion
approved these changes
Jun 9, 2022
crisbeto
commented
Jun 9, 2022
| @@ -72,7 +72,7 @@ function addAnimationsModule(options: Schema) { | |||
| try { | |||
| addAnimationsModuleToNonStandaloneApp(host, project, context, options); | |||
| } catch (e) { | |||
| if (e instanceof SchematicsException && e.message.includes('Bootstrap call not found')) { | |||
| if (e instanceof Error && e.message.includes('Bootstrap call not found')) { | |||
There was a problem hiding this comment.
I made this change, because I ended up with a version mismatch between some of the Tooling packages by accident which broke the check here. Checking against Error instead should be more robust.
There was a problem hiding this comment.
FWIW: Amy and I had a similar issue last time where even instanceof Error did not work due to the devkit executing schematics in a different VM context. Might not be an issue here since it throws in the same VM context, but worth mentioning.. not ideal
Bumps up the repo to the stable version of Angular 14.
crisbeto
added
action: merge
crisbeto
added a commit
that referenced
this pull request
Jun 9, 2022
Bumps up the repo to the stable version of Angular 14. (cherry picked from commit 13d257c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps up the repo to the stable version of Angular 14.