Skip to content

build: update to the latest version of dev-infra with ESM #25052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2022

Conversation

devversion
Copy link
Member

Updates to the latest version of dev-infra with full ESM.

@devversion devversion force-pushed the build/update-dev-infra-to-esm branch 3 times, most recently from a784ad5 to 1a6a094 Compare June 10, 2022 17:35
@devversion devversion requested a review from josephperrott June 10, 2022 17:40
@devversion devversion marked this pull request as ready for review June 10, 2022 17:40
@devversion devversion requested review from a team, andrewseguin and jelbourn as code owners June 10, 2022 17:40
@devversion
Copy link
Member Author

(As a follow-up I want to dedupe the yarn lock file of the components repo. There is a lot of stuff that we duplicate)

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion force-pushed the build/update-dev-infra-to-esm branch from 1a6a094 to d7e83fa Compare June 11, 2022 11:07
@devversion devversion added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge safe labels Jun 11, 2022
@devversion devversion merged commit 621f209 into angular:main Jun 11, 2022
devversion added a commit that referenced this pull request Jun 11, 2022
* build: update to the latest version of dev-infra with ESM

Updates to the latest version of dev-infra with full ESM.

* build: enable `--strict` for tools typescript code

* build: update notify slack script to ESM as it imports from `ng-dev`

(cherry picked from commit 621f209)
@devversion devversion deleted the build/update-dev-infra-to-esm branch June 11, 2022 11:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants