Skip to content

build: fix yarn merge script alias since it wasn't using ts-node #25126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2022
Merged

build: fix yarn merge script alias since it wasn't using ts-node #25126

merged 1 commit into from
Jun 21, 2022

Conversation

devversion
Copy link
Member

The yarn merge script directly calls into ng-dev but should instead
go through the ng-dev yarn script alias we have (the one that wires
up TSNode for the config loading).

@devversion
build: fix yarn merge script alias since it wasn't using ts-node
1498d06 
The `yarn merge` script directly calls into `ng-dev` but should instead
go through the `ng-dev` yarn script alias we have (the one that wires
up TSNode for the config loading).
@devversion devversion requested a review from crisbeto June 21, 2022 13:15
@devversion devversion requested a review from a team as a code owner June 21, 2022 13:15
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Jun 21, 2022
josephperrott
josephperrott approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 21, 2022
@devversion devversion merged commit 3fe1498 into angular:main Jun 21, 2022
devversion added a commit that referenced this pull request Jun 21, 2022
@devversion
build: fix yarn merge script alias since it wasn't using ts-node (#…
7a0753c 
…25126)

The `yarn merge` script directly calls into `ng-dev` but should instead
go through the `ng-dev` yarn script alias we have (the one that wires
up TSNode for the config loading).

(cherry picked from commit 3fe1498)
@devversion devversion deleted the fix-yarn-merge-alias branch June 21, 2022 14:58
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 27, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devversion @josephperrott