Skip to content

refactor: explicitly set the display of the mat-paginator-icon to inline #25140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2022
Merged

refactor: explicitly set the display of the mat-paginator-icon to inline #25140

merged 1 commit into from
Jul 22, 2022

Conversation

ahasall
Copy link
Contributor

@ahasall ahasall commented Jun 22, 2022 •
edited
Loading

Some CSS resets like Tailwind's Preflight set the display value of the SVG element to block which break the design
of the mat-paginator-icon by making it not properly centered inside the button.

Before

Screenshot 2022-06-22 at 23 32 33

After

Screenshot 2022-06-22 at 23 32 00

@ahasall ahasall requested a review from andrewseguin as a code owner June 22, 2022 21:35
@ahasall ahasall force-pushed the refactor/mat-paginator-icon-inline branch from 43bcdd4 to 6a2c117 Compare June 22, 2022 21:36
crisbeto
crisbeto reviewed Jun 23, 2022
View reviewed changes
@ahasall ahasall force-pushed the refactor/mat-paginator-icon-inline branch from 6a2c117 to 82365cc Compare June 23, 2022 07:09
crisbeto
crisbeto approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 23, 2022
@crisbeto
Copy link
Member

Actually I just realized that we'll need the same change in src/material-experimental/mdc-paginator/paginator.scss.

@crisbeto crisbeto removed the action: merge The PR is ready for merge by the caretaker label Jun 23, 2022
@ahasall
refactor: explicitly set the display of the mat-paginator-icon to inline
658fcf8 
Some CSS resets set the `display` value of the SVG element to `block` which break the design
of the mat-paginator-icon by making it not properly centered inside the button.
@ahasall ahasall force-pushed the refactor/mat-paginator-icon-inline branch from 82365cc to 658fcf8 Compare June 23, 2022 07:27
@ahasall
Copy link
Contributor Author

ahasall commented Jun 23, 2022

Actually I just realized that we'll need the same change in src/material-experimental/mdc-paginator/paginator.scss.

Done.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 23, 2022
@amysorto amysorto merged commit a36f022 into angular:main Jul 22, 2022
amysorto pushed a commit that referenced this pull request Jul 22, 2022
@ahasall @amysorto
refactor: explicitly set the display of the mat-paginator-icon to inl…
b50ecd1 
…ine (#25140)

Some CSS resets set the `display` value of the SVG element to `block` which break the design
of the mat-paginator-icon by making it not properly centered inside the button.

(cherry picked from commit a36f022)
amysorto pushed a commit that referenced this pull request Jul 22, 2022
@ahasall @amysorto
refactor: explicitly set the display of the mat-paginator-icon to inl…
1cf68dd 
…ine (#25140)

Some CSS resets set the `display` value of the SVG element to `block` which break the design
of the mat-paginator-icon by making it not properly centered inside the button.

(cherry picked from commit a36f022)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahasall @crisbeto @amysorto