build: dependencies duplicated when deploying snapshots #25152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were adding a `resolutions` field to the package.json of the docs site when deploying it from the main repo to try and control the version that is installed. This appears to be causing an issue where Yarn duplicates the dependencies which in turn causes Webpack to bundle them once for the main site and another for the lazy-loaded chunks with the examples. These changes resolve the issue by not adding the `resolutions` field. For reference, currently the docs package depends on `@angular/[email protected]+sha-7d87068-with-local-changes` whereas the docs site depends on `@angular/cdk@file://path/to/repo/dist/releases/cdk`. Fixes angular#24992.
crisbeto
force-pushed
the
24992/docs-duplicate-deps
branch
from
1258bd5 to
73e986f
Compare
crisbeto
added
P2
devversion
approved these changes
Jun 24, 2022
crisbeto
added a commit
that referenced
this pull request
Jun 24, 2022
We were adding a `resolutions` field to the package.json of the docs site when deploying it from the main repo to try and control the version that is installed. This appears to be causing an issue where Yarn duplicates the dependencies which in turn causes Webpack to bundle them once for the main site and another for the lazy-loaded chunks with the examples. These changes resolve the issue by not adding the `resolutions` field. For reference, currently the docs package depends on `@angular/[email protected]+sha-7d87068-with-local-changes` whereas the docs site depends on `@angular/cdk@file://path/to/repo/dist/releases/cdk`. Fixes #24992. (cherry picked from commit 4cedd6b)
crisbeto
added a commit
that referenced
this pull request
Jun 24, 2022
We were adding a `resolutions` field to the package.json of the docs site when deploying it from the main repo to try and control the version that is installed. This appears to be causing an issue where Yarn duplicates the dependencies which in turn causes Webpack to bundle them once for the main site and another for the lazy-loaded chunks with the examples. These changes resolve the issue by not adding the `resolutions` field. For reference, currently the docs package depends on `@angular/[email protected]+sha-7d87068-with-local-changes` whereas the docs site depends on `@angular/cdk@file://path/to/repo/dist/releases/cdk`. Fixes #24992. (cherry picked from commit 4cedd6b)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were adding a
resolutionsfield to the package.json of the docs site when deploying it from the main repo to try and control the version that is installed. This appears to be causing an issue where Yarn duplicates the dependencies which in turn causes Webpack to bundle them once for the main site and another for the lazy-loaded chunks with the examples. These changes resolve the issue by not adding theresolutionsfield.For reference, currently the docs package depends on
@angular/[email protected]+sha-7d87068-with-local-changeswhereas the docs site depends on@angular/cdk@file://path/to/repo/dist/releases/cdk.Fixes #24992.