docs(material/autocomplete): use single map instead of two maps in a row #25167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example code is highly trusted and sometimes taken as is (copy-paste), so it is important to have it optimized if possible. Each map means an iteration over the array items. By using single map, an iteration is saved, and an approximate performance of about 38% is won.
crisbeto
added
docs
crisbeto
pushed a commit
that referenced
this pull request
Jun 27, 2022
…row (#25167) * docs(material/autocomplete): use single map instead of two maps in a row The example code is highly trusted and sometimes taken as is (copy-paste), so it is important to have it optimized if possible. Each map means an iteration over the array items. By using single map, an iteration is saved, and an approximate performance of about 38% is won. * docs(material/autocomplete): add trailing comma (cherry picked from commit 8ca012f)
crisbeto
pushed a commit
that referenced
this pull request
Jun 27, 2022
…row (#25167) * docs(material/autocomplete): use single map instead of two maps in a row The example code is highly trusted and sometimes taken as is (copy-paste), so it is important to have it optimized if possible. Each map means an iteration over the array items. By using single map, an iteration is saved, and an approximate performance of about 38% is won. * docs(material/autocomplete): add trailing comma (cherry picked from commit 8ca012f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The example code is highly trusted and sometimes
taken as is (copy-paste), so it is important to
have it optimised if possible.
what
Each map means an iteration over the array items.
By using single map, an iteration is saved, and
an approximate performance of about 38% is won.
I measured the performance here: https://jsbench.me/dbl4wkw3r9/1