Skip to content

fix(material/select): add selected indication in high contrast mode #25237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 7, 2022

Currently we don't indicate which mat-option is selected in single-selection mode to high contrast users. These changes add a small indicator similar to the one in mat-selection-list.

Currently we don't indicate which `mat-option` is selected in single-selection mode to high contrast users. These changes add a small indicator similar to the one in `mat-selection-list`.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Jul 7, 2022
@crisbeto crisbeto requested review from zarend and mmalerba July 7, 2022 07:13
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jul 7, 2022
@crisbeto crisbeto merged commit 5c8c7e8 into angular:main Jul 11, 2022
crisbeto added a commit that referenced this pull request Jul 11, 2022
…25237)

Currently we don't indicate which `mat-option` is selected in single-selection mode to high contrast users. These changes add a small indicator similar to the one in `mat-selection-list`.

(cherry picked from commit 5c8c7e8)
crisbeto added a commit that referenced this pull request Jul 11, 2022
…25237)

Currently we don't indicate which `mat-option` is selected in single-selection mode to high contrast users. These changes add a small indicator similar to the one in `mat-selection-list`.

(cherry picked from commit 5c8c7e8)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jul 18, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.0.4/14.0.5) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.0.4/14.0.5) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.0.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1405-metal-hamster-2022-07-14)

[Compare Source](angular/components@14.0.4...14.0.5)

##### cdk

| Commit | Type | Description |
| -- | -- | -- |
| [9cd5a6ad70](angular/components@9cd5a6a) | fix | **a11y:** correctly detect focus from input label ([#&#8203;25232](angular/components#25232)) |
| [938aa2fa13](angular/components@938aa2f) | fix | **clipboard:** page jumping on iOS ([#&#8203;25221](angular/components#25221)) |

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [f5bdefe6fd](angular/components@f5bdefe) | fix | **checkbox:** broken appearance in some grid layouts ([#&#8203;25197](angular/components#25197)) |
| [25ce8e775c](angular/components@25ce8e7) | fix | **select:** add selected indication in high contrast mode ([#&#8203;25237](angular/components#25237)) |
| [76c0e9c1cd](angular/components@76c0e9c) | fix | **tabs:** ink bar not shown in some cases ([#&#8203;25218](angular/components#25218)) |

##### material-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [a9c7f59240](angular/components@a9c7f59) | fix | **mdc-button:** always treat icon-button content as an icon ([#&#8203;25200](angular/components#25200)) |
| [7101a91ef5](angular/components@7101a91) | fix | **mdc-form-field:** ensure clip-path does not truncate label early ([#&#8203;25264](angular/components#25264)) |
| [84a4e9a742](angular/components@84a4e9a) | fix | **mdc-form-field:** fix notch visual artifact ([#&#8203;25201](angular/components#25201)) |
| [ce7f42b912](angular/components@ce7f42b) | fix | **mdc-form-field:** use a CSS var for the floating label scale ([#&#8203;25178](angular/components#25178)) |
| [c0716784b2](angular/components@c071678) | fix | **mdc-paginator:** allow form-field density to go lower than -4 ([#&#8203;25192](angular/components#25192)) |

#####

| Commit | Type | Description |
| -- | -- | -- |
| [89bc64a329](angular/components@89bc64a) | fix | making the parse format available for native date adapter extension ([#&#8203;25226](angular/components#25226)) |

##### multiple

| Commit | Type | Description |
| -- | -- | -- |
| [68edf42798](angular/components@68edf42) | fix | fix disabled label style ([#&#8203;25181](angular/components#25181)) |

#### Special Thanks

Andrew Seguin, Kai Schönberger, Kristiyan Kostadinov, Miles Malerba, Oliver Kierepka and Paul Gschwendtner

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTIuMCIsInVwZGF0ZWRJblZlciI6IjMyLjExNS4wIn0=-->

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1463
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants