Skip to content

fix(material/card): don't add extra padding around mat-card-title-group #25292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2022
Merged

fix(material/card): don't add extra padding around mat-card-title-group #25292

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6a53f8
fix(material/card): don't add extra padding around mat-card-title-group
mmalerba Jul 15, 2022
30a3152
fixup! fix(material/card): don't add extra padding around mat-card-ti…
mmalerba Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 42 additions & 26 deletions src/dev-app/mdc-card/mdc-card-demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@
</mat-card>

<mat-card [appearance]="appearance">
<mat-card-subtitle>Subtitle</mat-card-subtitle>
<mat-card-title>Card with title and footer</mat-card-title>
<mat-card-header>
<mat-card-subtitle>Subtitle</mat-card-subtitle>
<mat-card-title>Card with title and footer</mat-card-title>
</mat-card-header>
<mat-card-content>
<p>This is supporting text.</p>
<p>{{longText}}</p>
Expand All @@ -26,8 +28,10 @@
</mat-card>

<mat-card [appearance]="appearance">
<mat-card-subtitle>Subtitle</mat-card-subtitle>
<mat-card-title>Card with title, footer, and inset-divider</mat-card-title>
<mat-card-header>
<mat-card-subtitle>Subtitle</mat-card-subtitle>
<mat-card-title>Card with title, footer, and inset-divider</mat-card-title>
</mat-card-header>
<mat-card-content>
<p>This is supporting text.</p>
<p>{{longText}}</p>
Expand All @@ -41,7 +45,9 @@

<mat-card [appearance]="appearance">
<img mat-card-image src="https://material.angularjs.org/latest/img/washedout.png">
<mat-card-title>Content Title</mat-card-title>
<mat-card-header>
<mat-card-title>Content Title</mat-card-title>
</mat-card-header>
<mat-card-content>
<p>Here is some content</p>
</mat-card-content>
Expand All @@ -64,7 +70,9 @@
</mat-card>

<mat-card class="demo-card-blue mat-card-flat" [appearance]="appearance">
<mat-card-title>Easily customizable</mat-card-title>
<mat-card-header>
<mat-card-title>Easily customizable</mat-card-title>
</mat-card-header>
<mat-card-actions>
<button mat-button>First</button>
<button mat-button>Second</button>
Expand All @@ -75,44 +83,52 @@
<h2>Cards with media area</h2>

<mat-card [appearance]="appearance">
<mat-card-title-group>
<mat-card-title>Card</mat-card-title>
<mat-card-subtitle>Small</mat-card-subtitle>
<img mat-card-sm-image>
</mat-card-title-group>
<mat-card-header>
<mat-card-title-group>
<mat-card-title>Card</mat-card-title>
<mat-card-subtitle>Small</mat-card-subtitle>
<img mat-card-sm-image>
</mat-card-title-group>
</mat-card-header>
<mat-card-content>
{{longText}}
</mat-card-content>
</mat-card>

<mat-card [appearance]="appearance">
<mat-card-title-group>
<mat-card-title>Card</mat-card-title>
<mat-card-subtitle>Medium</mat-card-subtitle>
<img mat-card-md-image>
</mat-card-title-group>
<mat-card-header>
<mat-card-title-group>
<mat-card-title>Card</mat-card-title>
<mat-card-subtitle>Medium</mat-card-subtitle>
<img mat-card-md-image>
</mat-card-title-group>
</mat-card-header>
<mat-card-content>
{{longText}}
</mat-card-content>
</mat-card>

<mat-card [appearance]="appearance">
<mat-card-title-group>
<mat-card-title>Card</mat-card-title>
<mat-card-subtitle>Large</mat-card-subtitle>
<img mat-card-lg-image>
</mat-card-title-group>
<mat-card-header>
<mat-card-title-group>
<mat-card-title>Card</mat-card-title>
<mat-card-subtitle>Large</mat-card-subtitle>
<img mat-card-lg-image>
</mat-card-title-group>
</mat-card-header>
<mat-card-content>
{{longText}}
</mat-card-content>
</mat-card>

<mat-card [appearance]="appearance">
<mat-card-title-group>
<mat-card-title>Card</mat-card-title>
<mat-card-subtitle>Extra large</mat-card-subtitle>
<img mat-card-xl-image>
</mat-card-title-group>
<mat-card-header>
<mat-card-title-group>
<mat-card-title>Card</mat-card-title>
<mat-card-subtitle>Extra large</mat-card-subtitle>
<img mat-card-xl-image>
</mat-card-title-group>
</mat-card-header>
<mat-card-content>
{{longText}}
</mat-card-content>
Expand Down
5 changes: 1 addition & 4 deletions src/material/card/card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,7 @@ $mat-card-default-padding: 16px !default;
// and subtitle go first (projected into a single div), followed by the media.
display: flex;
justify-content: space-between;

// Apply default padding for the title-group region. Omit any bottom padding because we assume
// this region will be followed by another region that includes top padding.
padding: $mat-card-default-padding $mat-card-default-padding 0;
width: 100%;
}

// Avatar image for a card. MDC does not specifically have a card avatar or a "common" avatar.
Expand Down