Skip to content

build: delete unused benchmark tests which do not build #25384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2022
Merged

build: delete unused benchmark tests which do not build #25384

merged 1 commit into from
Aug 2, 2022

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Aug 2, 2022

No description provided.

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Aug 2, 2022
wagnermaciel
wagnermaciel approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker merge safe target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Aug 2, 2022
@wagnermaciel wagnermaciel merged commit f3019e9 into angular:main Aug 2, 2022
wagnermaciel pushed a commit that referenced this pull request Aug 2, 2022
@mmalerba @wagnermaciel
build: delete unused benchmark tests which do not build (#25384)
79a96c1
wagnermaciel added a commit that referenced this pull request Aug 2, 2022
@wagnermaciel
Revert "build: delete unused benchmark tests which do not build (#25384…
e9a76b1 
…)"

This reverts commit 79a96c1.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Aug 3, 2022
@mmalerba @wagnermaciel
build: delete unused benchmark tests which do not build (angular#25384)
3deb9d3
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Aug 3, 2022
@wagnermaciel
fixup! build: delete unused benchmark tests which do not build (angul…
9bcbf67 
…ar#25384)
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Aug 3, 2022
@wagnermaciel
fixup! build: delete unused benchmark tests which do not build (angul…
e888e09 
…ar#25384)
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Aug 3, 2022
@wagnermaciel
fixup! build: delete unused benchmark tests which do not build (angul…
9096aed 
…ar#25384)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Aug 3, 2022
@mmalerba @wagnermaciel
build: delete unused benchmark tests which do not build (angular#25384)
b49b58e
wagnermaciel added a commit that referenced this pull request Aug 3, 2022
@wagnermaciel @mmalerba
build: delete unused benchmark tests which do not build (#25384) (#25385
321065d 
)

Co-authored-by: Miles Malerba <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@devversion devversion Awaiting requested review from devversion

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@wagnermaciel wagnermaciel

Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalerba @wagnermaciel