Skip to content

fix(material/select): fix arrow alignment #25626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2022
Merged

fix(material/select): fix arrow alignment #25626

merged 1 commit into from
Sep 14, 2022

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Sep 12, 2022 •
edited
Loading

before:
select-before

after:
select-after

@mmalerba mmalerba changed the title WIP: fix(material/select): fix arrow alignment fix(material/select): fix arrow alignment Sep 12, 2022
@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Sep 12, 2022
@mmalerba mmalerba marked this pull request as ready for review September 12, 2022 21:23
wagnermaciel
wagnermaciel approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Sep 12, 2022
crisbeto
crisbeto approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 9be94a0 into angular:main Sep 14, 2022
@mmalerba mmalerba deleted the select-arrow branch September 14, 2022 16:13
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Sep 16, 2022
@mmalerba
fix(material/select): fix arrow alignment (angular#25626)
bc41e3b
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @crisbeto @wagnermaciel