Skip to content

fix(cdk/drag-drop): native event not passed as parameter to drop container #25763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

jokecamp
Copy link
Contributor

@jokecamp jokecamp commented Oct 5, 2022

Fixes a bug where native event was always an empty object because it was not passed to the container drop function and the default {} object was always used.

…entialsContainer

Fixes a bug where native event was always an empty object because it was not passed to the container drop function and the default `{}` object was always used.
@jokecamp jokecamp requested a review from crisbeto as a code owner October 5, 2022 13:37
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 5, 2022
@angular-robot angular-robot bot requested a review from crisbeto October 5, 2022 23:59
@jokecamp
Copy link
Contributor Author

jokecamp commented Oct 6, 2022

Added another commit for formatting. Added the missing trailing comma.

@crisbeto crisbeto added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 6, 2022
@devversion devversion merged commit 72547a4 into angular:main Oct 6, 2022
devversion pushed a commit that referenced this pull request Oct 6, 2022
…ainer (#25763)

* fix(cdk/drag-drop): native event not passed as parameter to drop CredentialsContainer

Fixes a bug where native event was always an empty object because it was not passed to the container drop function and the default `{}` object was always used.

* fix(cdk/drag-drop): Added missing trailing comma
@jokecamp jokecamp deleted the fix-missing-drop-event branch October 6, 2022 13:27
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Oct 13, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.2.4` -> `14.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.2.4/14.2.5) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.2.4` -> `14.2.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.2.4/14.2.5) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.2.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1425-hail-heron-2022-10-12)

[Compare Source](angular/components@14.2.4...14.2.5)

##### cdk

| Commit | Type | Description |
| -- | -- | -- |
| [b116f57d16](angular/components@b116f57) | fix | **drag-drop:** native event not passed as parameter to drop container ([#&#8203;25763](angular/components#25763)) |

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [79eab3838d](angular/components@79eab38) | fix | **icon:** forward fontIcon attribute to element ([#&#8203;25779](angular/components#25779)) |

#### Special Thanks

Joe K, Joey Perrott and Kristiyan Kostadinov

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjIzNi4xIn0=-->

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1583
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants