fix(material/menu): custom origin in focusFirstItem not respected on open #25812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…open A while ago we added an `NgZone.onStable` wrapped around the logic that moves focus in `MatMenu.focusFirstItem` in order to work around an issue with VoiceOver. Since focus is now delayed, calling `focusFirstItem` in quick succession with different origins may not work as expected. These changes unsubscribe from the previous `onStable` callback if a new one comes in before it has finished. Fixes angular#25658.
crisbeto
added
P3
crisbeto
added
action: merge
crisbeto
added a commit
that referenced
this pull request
Oct 15, 2022
…open (#25812) A while ago we added an `NgZone.onStable` wrapped around the logic that moves focus in `MatMenu.focusFirstItem` in order to work around an issue with VoiceOver. Since focus is now delayed, calling `focusFirstItem` in quick succession with different origins may not work as expected. These changes unsubscribe from the previous `onStable` callback if a new one comes in before it has finished. Fixes #25658. (cherry picked from commit c0efe14)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago we added an
NgZone.onStablewrapper around the logic that moves focus inMatMenu.focusFirstItemin order to work around an issue with VoiceOver. Since focus is now delayed, callingfocusFirstItemin quick succession with different origins may not work as expected.These changes unsubscribe from the previous
onStablecallback if a new one comes in before it has finished.Fixes #25658.