docs(material/slide-toggle): update changes from legacy #25825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
docs
crisbeto
reviewed
Oct 18, 2022
|
|
||
| <mat-slide-toggle name="slideToggle" required ngModel> | ||
| <mat-slide-toggle name="slideToggle" ngModel="[(formToggle)]"> |
There was a problem hiding this comment.
what doesn't look right about it? required attribute doesn't work, since this is a button role="switch". I also added the binding to formToggle, so that it can alert the value of the toggle when submitting the form.
There was a problem hiding this comment.
The syntax on the ngModel binding is wrong.
There was a problem hiding this comment.
ohh, that's not the right syntax 🤦 🍌 📦. I corrected the syntax, thanks.
Update migration guide for MDC Slide Toggle to give more detail on form validation. Remove form validation from slide-toggle example as it does not seem to be appropriate for switch role. Update slide toggle overview documentation to reflect changes for the MDC-based slide toggle.
zarend
force-pushed
the
slide-toggle-docs
branch
from
e219c45 to
af30754
Compare
zarend
added
action: merge
zarend
added a commit
that referenced
this pull request
Oct 21, 2022
Update migration guide for MDC Slide Toggle to give more detail on form validation. Remove form validation from slide-toggle example as it does not seem to be appropriate for switch role. Update slide toggle overview documentation to reflect changes for the MDC-based slide toggle. (cherry picked from commit 7456712)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update migration guide for MDC Slide Toggle to give more detail on form validation. Remove form validation from slide-toggle example as it does not seem to be appropriate for switch role. Update slide toggle overview documentation to reflect changes for the MDC-based slide toggle.